I reviewed Pirate Software's code. Oh boy...

About this Video

• Video Title: I reviewed Pirate Software's code. Oh boy...
• Channel: Coding Jesus
• Speakers: Coding Jesus (Jason Thorhol)
• Duration: 00:13:13

Introduction

This video presents a code review of code samples from YouTuber and streamer Thor (Pirate Software). The reviewer, Coding Jesus, analyzes the code for issues related to maintainability, readability, and best practices, questioning Thor's claimed expertise as a 20-year veteran game developer. The review is contextualized within a discussion of Thor's stance on the "Stop Killing Games" movement.

Key Takeaways

• Poor Code Quality: The reviewed code demonstrates significant issues, including excessive use of magic numbers, inadequate use of data types, and a lack of descriptive variable names. The code is described as "spaghetti code" and a "maintainability nightmare".
• Inadequate Data Type Usage: The video highlights the misuse of data types, such as using integers where booleans would be appropriate, leading to code that is less readable and prone to errors.
• Over-Reliance on Comments: The code contains excessive comments, indicating a lack of self-documenting code. The reviewer argues that well-written code should be largely self-explanatory.
• Suboptimal Data Structures: The use of a flat, one-dimensional array to represent a timeline of events is criticized for its lack of structure and maintainability. The reviewer suggests using a nested structure or storing data externally in a configuration file (YAML or XML).
• Lack of Professionalism: The reviewer notes that Thor’s dev streams focus more on viewer interaction and unrelated activities rather than actual coding, further challenging his credibility.