Linus Torvalds Calls Out RISC-V for "Garbage" Code

About this Video

• Video Title: Linus Torvalds Calls Out RISC-V for "Garbage" Code
• Channel: SavvyNik
• Speakers: Linus Torvalds, Palmer (implied)
• Duration: 00:13:12

Introduction

This video analyzes an exchange between Linus Torvalds and a contributor (Palmer) regarding a RISC-V architecture update for the Linux 6.17 kernel. Torvalds rejected the pull request, deeming parts of the code "garbage," due to issues with code quality, timing of submission, and scope creep. The video explores the details of the rejected code and Torvalds' critique.

Key Takeaways

• Torvalds rejected a RISC-V pull request for Linux 6.17, labeling parts as "garbage." The rejection stemmed from concerns about code quality, the late submission timing, and the inclusion of non-RISC-V specific code in generic header files.
• The contentious code included a helper function (make U32 from 2 U16) considered unnecessarily obfuscated and detrimental to code readability. Torvalds preferred a more explicit approach, arguing that the helper function hindered understanding and could negatively impact other architectures.
• The late submission during the merge window was a significant factor in Torvalds' rejection. The late submission limited time for review, testing, and discussion, increasing the risk of untested code entering the kernel.
• Torvalds emphasized the importance of clear, explicit code, timely submissions, and respecting the Linux kernel development process. He stressed that contributors should avoid scope creep and limit changes to their respective code areas.
• Palmer responded apologetically, admitting to dropping the ball and promising to submit future pull requests earlier. His response was viewed as professional and focused on a solution, contrasting with potentially defensive reactions seen in similar situations.